linux-kernel - Re: [RFC][PATCHSET v2] allowing exports in *.S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57B2AB42.2090600@suse.com>
Date:	Tue, 16 Aug 2016 07:57:22 +0200
From:	Michal Marek <mmarek@...e.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-arch@...r.kernel.org, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCHSET v2] allowing exports in *.S

Dne 16.8.2016 v 07:48 Michal Marek napsal(a):
> Dne 2.8.2016 v 16:01 Michal Marek napsal(a):
>> On 2016-02-03 22:19, Al Viro wrote:
>>> Shortlog:
>>> Al Viro (13):
>>>       [kbuild] handle exports in lib-y objects reliably
>>>       EXPORT_SYMBOL() for asm
>>>       x86: move exports to actual definitions
>>>       alpha: move exports to actual definitions
>>>       m68k: move exports to definitions
>>>       s390: move exports to definitions
>>>       arm: move exports to definitions
>>>       ppc: move exports to definitions
>>>       ppc: get rid of unreachable abs() implementation
>>>       sparc: move exports to definitions
>>>       [sparc] unify 32bit and 64bit string.h
>>>       sparc32: debride memcpy.S a bit
>>>       ia64: move exports to definitions
>>
>> After several pings by Al (sorry about that!), I got around to review a
>> rebased version of this patchset at
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git asm-exports
>>
>> The kbuild commits are good, but since we are close to the end of the
>> merge window, I will apply them to my kbuild branch after 4.8-rc1.
> 
> The rebased patchset is now in kbuild.git#kbuild. Before pushing, I
> noticed one issue: For some reason,
> drivers/firmware/efi/libstub/lib-ksyms.o is regenerated each time,
> leading to relink of vmlinux. I'm looking into this.

OK, it's the

$(obj)/lib-%.o: $(srctree)/lib/%.c FORCE
        $(call if_changed_rule,cc_o_c)

rule in drivers/firmware/efi/libstub/Makefile file that conflicts with
the lib-ksyms.o rule. I need to find a better solution to this hack.

Michal