linux-kernel - Re: [PATCH] nvme-rdma: initialize ret to zero to avoid returning garbage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d8071d3-aa97-f963-4246-a4872c83a927@grimberg.me>
Date:	Tue, 16 Aug 2016 12:06:18 +0300
From:	Sagi Grimberg <sagi@...mberg.me>
To:	Colin King <colin.king@...onical.com>,
	Keith Busch <keith.busch@...el.com>, Jens Axboe <axboe@...com>,
	linux-nvme@...ts.infradead.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme-rdma: initialize ret to zero to avoid returning
 garbage



On 16/08/16 11:24, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> ret is not initialized so it contains garbage.  Ensure garbage
> is not returned by initializing rc to 0.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/nvme/host/rdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 8d2875b..9c69393 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1319,7 +1319,7 @@ out_destroy_queue_ib:
>  static int nvme_rdma_device_unplug(struct nvme_rdma_queue *queue)
>  {
>  	struct nvme_rdma_ctrl *ctrl = queue->ctrl;
> -	int ret;
> +	int ret = 0;
>
>  	/* Own the controller deletion */
>  	if (!nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_DELETING))
>

Applied for the next round of rc fixes.

Thanks Colin.