linux-kernel - Re: [RESEND][PATCH] pinctrl: exynos: remove duplicate calls in irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <41a0d7c4-c199-0c1a-a861-10ba25337594@samsung.com>
Date:	Tue, 16 Aug 2016 11:16:10 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	perr perr <strongbox8@...o.com>, tomasz.figa@...il.com
Cc:	s.nawrocki@...sung.com, linus.walleij@...aro.org, kgene@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND][PATCH] pinctrl: exynos: remove duplicate calls in irq
 handler

On 08/16/2016 08:49 AM, perr perr wrote:
> Because chained_irq_enter() has already called chip->irq_mask() and 
> chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), 
> so it's not necessary to call chip->irq_*() here. 
>  
> Signed-off-by: Perr Zhang<strongbox8@...o.com> 
>  
> --- 
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- 
>  1 file changed, 1 insertion(+), 5 deletions(-) 

Hi,

Thanks for fixing Signed-off-by but now the commiter name does not match
Signed-off-by. In the same time you skipped the tags you got already
(Tomasz's ack and my reviewed-by).

BR,
Krzysztof

>  
> diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c 
> index 051b5bf..d32fa2b 100644 
> --- a/drivers/pinctrl/samsung/pinctrl-exynos.c 
> +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c 
> @@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc) 
>      int eint_irq; 
>   
>      chained_irq_enter(chip, desc); 
> -    chip->irq_mask(&desc->irq_data); 
> - 
> -    if (chip->irq_ack) 
> -        chip->irq_ack(&desc->irq_data); 
>   
>      eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq); 
>      generic_handle_irq(eint_irq); 
> -    chip->irq_unmask(&desc->irq_data); 
> + 
>      chained_irq_exit(chip, desc); 
>  } 
>   
> --  
> 1.9.3 
>  
> 
> 
>