linux-kernel - Re: [PATCH] extcon: Use the extcon_set_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Aug 2016 12:24:06 +0300
From:	Roger Quadros <rogerq@...com>
To:	Chanwoo Choi <cw00.choi@...sung.com>,
	<linux-kernel@...r.kernel.org>
CC:	<chanwoo@...nel.org>, <myungjoo.ham@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
	Chen-Yu Tsai <wens@...e.org>,
	Ramakrishna Pallala <ramakrishna.pallala@...el.com>,
	Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCH] extcon: Use the extcon_set_state_sync() instead of
 deprecated functions

Hi,

On 16/08/16 10:08, Chanwoo Choi wrote:
> This patch alters the renamed extcon API to set the state of the external
> connectors instead of deprecated extcon_set_cable_state_().
> 
> Because the patch[1] modifies the function name to maintain the function
> naming pattern.
> - extcon_set_cable_state_() -> extcon_set_state_sync()
> - extcon_get_cable_state_() -> extcon_get_state()
> 
> [1] https://lkml.org/lkml/2016/8/4/729
> - extcon: Rename the extcon_set/get_state() to maintain the function naming pattern
> 
> Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Cc: Roger Quadros <rogerq@...com>
> Cc: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> Cc: Chen-Yu Tsai <wens@...e.org>
> Cc: Ramakrishna Pallala <ramakrishna.pallala@...el.com>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---
>  drivers/extcon/extcon-adc-jack.c |  4 ++--
>  drivers/extcon/extcon-arizona.c  | 16 +++++++-------
>  drivers/extcon/extcon-axp288.c   |  2 +-
>  drivers/extcon/extcon-gpio.c     |  2 +-
>  drivers/extcon/extcon-max14577.c | 14 ++++++------
>  drivers/extcon/extcon-max3355.c  |  8 +++----
>  drivers/extcon/extcon-max77693.c | 46 ++++++++++++++++++++--------------------
>  drivers/extcon/extcon-max77843.c | 22 +++++++++----------
>  drivers/extcon/extcon-max8997.c  | 20 ++++++++---------
>  drivers/extcon/extcon-palmas.c   | 16 +++++++-------
>  drivers/extcon/extcon-rt8973a.c  |  4 ++--
>  drivers/extcon/extcon-sm5502.c   |  4 ++--
>  drivers/extcon/extcon-usb-gpio.c |  8 +++----
>  13 files changed, 83 insertions(+), 83 deletions(-)

for extcon-usb-gpio.c

Acked-by: Roger Quadros <rogerq@...com>

cheers,
-roger