linux-kernel - Re: [PATCH] platform: olpc: make ec explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160815180120.24e46394@e7450.queued.net>
Date:	Mon, 15 Aug 2016 18:01:20 -0700
From:	Andres Salomon <dilinger@...ued.net>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	<linux-kernel@...r.kernel.org>, Darren Hart <dvhart@...radead.org>,
	<platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] platform: olpc: make ec explicitly non-modular

Fine by me.

Acked-by: Andres Salomon <dilinger@...ued.net>

On Mon, 15
Aug 2016 18:25:17 -0400 Paul Gortmaker <paul.gortmaker@...driver.com>
wrote:

> The Kconfig entry controlling compilation of this code is:
> 
> arch/x86/Kconfig:config OLPC
> arch/x86/Kconfig:       bool "One Laptop Per Child support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Darren Hart <dvhart@...radead.org>
> Cc: Andres Salomon <dilinger@...ued.net>
> Cc: platform-driver-x86@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/platform/olpc/olpc-ec.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/olpc/olpc-ec.c
> b/drivers/platform/olpc/olpc-ec.c index f99b183d5296..374a8028fec7
> 100644 --- a/drivers/platform/olpc/olpc-ec.c
> +++ b/drivers/platform/olpc/olpc-ec.c
> @@ -1,6 +1,8 @@
>  /*
>   * Generic driver for the OLPC Embedded Controller.
>   *
> + * Author: Andres Salomon <dilinger@...ued.net>
> + *
>   * Copyright (C) 2011-2012 One Laptop per Child Foundation.
>   *
>   * Licensed under the GPL v2 or later.
> @@ -12,7 +14,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/workqueue.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/list.h>
>  #include <linux/olpc-ec.h>
>  #include <asm/olpc.h>
> @@ -326,8 +328,4 @@ static int __init olpc_ec_init_module(void)
>  {
>  	return platform_driver_register(&olpc_ec_plat_driver);
>  }
> -
>  arch_initcall(olpc_ec_init_module);
> -
> -MODULE_AUTHOR("Andres Salomon <dilinger@...ued.net>");
> -MODULE_LICENSE("GPL");