linux-kernel - Re: [PATCH] crypto: fix ctx pointer and digest copy in sha256-mb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160816095252.GD27042@gondor.apana.org.au>
Date:	Tue, 16 Aug 2016 17:52:52 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Xiaodong Liu <xiaodong.liu@...el.com>
Cc:	linux-crypto@...r.kernel.org, tim.c.chen@...ux.intel.com,
	megha.dey@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: fix ctx pointer and digest copy in sha256-mb

On Fri, Aug 12, 2016 at 06:24:42AM -0400, Xiaodong Liu wrote:
> 1. fix ctx pointer
> Use req_ctx which is the ctx for the next job that have
> been completed in the lanes instead of the first
> completed job rctx, whose completion could have been
> called and released.
> 2. fix digest copy
> Use XMM register to copy another 16 bytes sha256 digest
> instead of a regular register.
> 
> Signed-off-by: Xiaodong Liu <xiaodong.liu@...el.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt