| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1471344210-7479-1-git-send-email-strongbox8@zoho.com> Date: Tue, 16 Aug 2016 18:43:30 +0800 From: Perr Zhang <strongbox8@...o.com> To: tomasz.figa@...il.com Cc: k.kozlowski@...sung.com, s.nawrocki@...sung.com, linus.walleij@...aro.org, kgene@...nel.org, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [RESEND][PATCH v2] remove duplicate calls in irq handler Because chained_irq_enter() has already called chip->irq_mask() and chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), so it's not necessary to call chip->irq_*() here. Signed-off-by: Perr Zhang <strongbox8@...o.com> Acked-by: Tomasz Figa <tomasz.figa@...il.com> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> --- drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index 051b5bf..d32fa2b 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc) int eint_irq; chained_irq_enter(chip, desc); - chip->irq_mask(&desc->irq_data); - - if (chip->irq_ack) - chip->irq_ack(&desc->irq_data); eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq); generic_handle_irq(eint_irq); - chip->irq_unmask(&desc->irq_data); + chained_irq_exit(chip, desc); } -- 1.9.3
Powered by blists - more mailing lists