linux-kernel - Re: [v.1] clocksource:clps711x-timer:- Unmap a region obtained by remap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57B30F68.4080701@linaro.org>
Date:	Tue, 16 Aug 2016 15:04:40 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Arvind Yadav <arvind.yadav.cs@...il.com>, tglx@...utronix.de
Cc:	shc_work@...l.ru, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [v.1] clocksource:clps711x-timer:- Unmap a region obtained by
 remap


Hi Arvind,

On 08/11/2016 07:41 PM, Arvind Yadav wrote:
> iounmap frees the mapping when timer id is not matching.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---

Even if this fix is correct, it does actually rollback a minimalist part
of what was done and only if the clock type is wrong. Can you properly
handle the undo from the different init functions and regarding their
success/error ?

Thanks.

  -- Daniel

>  drivers/clocksource/clps711x-timer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clocksource/clps711x-timer.c b/drivers/clocksource/clps711x-timer.c
> index 84aed78..deaca51 100644
> --- a/drivers/clocksource/clps711x-timer.c
> +++ b/drivers/clocksource/clps711x-timer.c
> @@ -116,6 +116,7 @@ static int __init clps711x_timer_init(struct device_node *np)
>  	case CLPS711X_CLKSRC_CLOCKEVENT:
>  		return _clps711x_clkevt_init(clock, base, irq);
>  	default:
> +		iounmap(base);
>  		return -EINVAL;
>  	}
>  }
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog