linux-kernel - Re: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2shu497si.fsf@baylibre.com>
Date:	Tue, 16 Aug 2016 08:12:45 -0500
From:	Kevin Hilman <khilman@...libre.com>
To:	Daniel Wagner <wagi@...om.org>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	Kamal Dasu <kdasu.kdev@...il.com>,
	Tim Kryger <tim.kryger@...aro.org>,
	Ray Jui <rjui@...adcom.com>,
	Daniel Wagner <daniel.wagner@...-carit.de>,
	linux-kernel@...r.kernel.org,
	Beniamino Galvani <b.galvani@...il.com>,
	bcm-kernel-feedback-list@...adcom.com, linux-i2c@...r.kernel.org,
	linux-amlogic@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all()

Daniel Wagner <wagi@...om.org> writes:

> From: Daniel Wagner <daniel.wagner@...-carit.de>
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> meson_i2c_xfer_msg()
>   reinit_completion()
>   ...
>   /* Start the transfer */
>   ...
>   wait_for_completion_timeout()
>
> Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>

Acked-by: Kevin Hilman <khilman@...libre.com>