linux-kernel - Re: [kbuild-all] make[2]: *** No rule to make target 'tools/testing/nvdimm//config_check.o', needed by 'tools/testing/nvdimm//dax.o'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160816014751.GC6835@localhost.localdomain>
Date:	Tue, 16 Aug 2016 09:47:52 +0800
From:	Yilong Ren <yilongx.ren@...el.com>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	Johannes Thumshirn <jthumshirn@...e.de>, kbuild-all@...org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [kbuild-all] make[2]: *** No rule to make target
 'tools/testing/nvdimm//config_check.o', needed by
 'tools/testing/nvdimm//dax.o'.

On Tue, Aug 16, 2016 at 09:41:02AM +0800, Fengguang Wu wrote:
> On Mon, Aug 15, 2016 at 06:30:48PM -0700, Dan Williams wrote:
> >On Mon, Aug 15, 2016 at 6:26 PM, Fengguang Wu <fengguang.wu@...el.com> wrote:
> >>On Mon, Aug 15, 2016 at 05:58:36PM -0700, Dan Williams wrote:
> >>>
> >>>On Mon, Aug 15, 2016 at 3:03 AM, kbuild test robot
> >>><fengguang.wu@...el.com> wrote:
> >>>>
> >>>>tree:
> >>>>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> >>>>head:   694d0d0bb2030d2e36df73e2d23d5770511dbc8d
> >>>>commit: ab68f26221366f92611650e8470e6a926801c7d4 /dev/dax, pmem: direct
> >>>>access to persistent memory
> >>>>date:   3 months ago
> >>>>config: i386-randconfig-i1-201633 (attached as .config)
> >>>>compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
> >>>>reproduce:
> >>>>        git checkout ab68f26221366f92611650e8470e6a926801c7d4
> >>>>        # save the attached .config to linux build tree
> >>>>        make ARCH=i386
> >>>>
> >>>>All errors (new ones prefixed by >>):
> >>>>
> >>>>>>make[2]: *** No rule to make target
> >>>>>>'tools/testing/nvdimm//config_check.o', needed by
> >>>>>>'tools/testing/nvdimm//dax.o'.
> >>>>
> >>>>   make[2]: Target '__build' not remade because of errors.
> >>>
> >>>
> >>>I think this is an invalid build test.  tools/testing/nvdimm/ uses a
> >>>external module Kbuild environment, not Kconfig.  So, there's nothing
> >>>I can do to prevent this compile error, unless there's some other way
> >>>0-day could determine the configuration dependencies?
> >>
> >>
> >>Yeah if you can offer a concrete rule for the dependency, we'll add
> >>it to 0-day.
> >
> >Sounds good.  The config_check.c file itself lists the dependencies:
> >
> >void check(void)
> >{
> >       /*
> >        * These kconfig symbols must be set to "m" for nfit_test to
> 
> If "y" is not a valid option, we'll need to adjust 0-day's dependency
> specification for ndctl test:
> 
> wfg /c/lkp-tests% cat include/ndctl
> need_kconfig:
> - CONFIG_HAVE_DMA_CONTIGUOUS=y
> - CONFIG_CMA=y
> - CONFIG_DMA_CMA=y
> - CONFIG_CMA_SIZE_MBYTES=200
> - CONFIG_LIBNVDIMM
> - CONFIG_BLK_DEV_PMEM
> - CONFIG_ND_BLK
> - CONFIG_BTT=y
> - CONFIG_NVDIMM_PFN=y
> - CONFIG_NVDIMM_DAX=y
> - CONFIG_ZONE_DEVICE=y
> 
> In the above list, a bare "CONFIG_BLK_DEV_PMEM" means "y" or "m" are
> both acceptable.

Yes, this is due to enable_module() can accept "y" and "m".
How about forcing enable_module() to accept "m" ?

 23 # CONFIG_XXX=m => unchange
 24 # CONFIG_XXX=y => unchange
 25 # CONFIG_XXX is not set => CONFIG_XXX=m
 26 enable_module()
 27 {
 28     grep -q -F -e "$1=m" -e "$1=y" .config && return  <======
 29 
 30     if [ -x source/scripts/config ]; then
 31         source/scripts/config --file .config --module $1
 32     else
 33         /kbuild/src/linux/scripts/config --file .config --module $1
 34     fi
 35 }

-- 
Thanks
Ren Yilong

> 
> >        * load and operate.
> >        */
> >       BUILD_BUG_ON(!IS_MODULE(CONFIG_LIBNVDIMM));
> >       BUILD_BUG_ON(!IS_MODULE(CONFIG_BLK_DEV_PMEM));
> >       BUILD_BUG_ON(!IS_MODULE(CONFIG_ND_BTT));
> >       BUILD_BUG_ON(!IS_MODULE(CONFIG_ND_PFN));
> >       BUILD_BUG_ON(!IS_MODULE(CONFIG_ND_BLK));
> >       BUILD_BUG_ON(!IS_MODULE(CONFIG_ACPI_NFIT));
> >       BUILD_BUG_ON(!IS_MODULE(CONFIG_DEV_DAX));
> >       BUILD_BUG_ON(!IS_MODULE(CONFIG_DEV_DAX_PMEM));
> 
> Regards,
> Fengguang