linux-kernel - Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160816173123.GA361@codeaurora.org>
Date:	Tue, 16 Aug 2016 10:31:23 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Michael Turquette <mturquette@...libre.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-clk <linux-clk@...r.kernel.org>,
	Denis Efremov <yefremov.denis@...il.com>
Subject: Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup
 function

On 08/16, Geert Uytterhoeven wrote:
> Hi Stephen,
> 
> On Sat, Aug 13, 2016 at 3:50 AM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> > This function is only called by builtin code, but we always
> > exported it and had marked it as __init before commit
> > e4eda8e0654c (clk: remove exported function from __init section,
> > 2013-01-06) removed that marking. Given that it isn't used by
> > modules, lets unexport it and add back __init.
> >
> > Cc: Denis Efremov <yefremov.denis@...il.com>
> > Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> > ---
> >  drivers/clk/clk-fixed-rate.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> > index c735272ed706..b5c46b3f8764 100644
> > --- a/drivers/clk/clk-fixed-rate.c
> > +++ b/drivers/clk/clk-fixed-rate.c
> > @@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node)
> >  /**
> >   * of_fixed_clk_setup() - Setup function for simple fixed rate clock
> >   */
> > -void of_fixed_clk_setup(struct device_node *node)
> > +void __init of_fixed_clk_setup(struct device_node *node)
> >  {
> >         _of_fixed_clk_setup(node);
> >  }
> > -EXPORT_SYMBOL_GPL(of_fixed_clk_setup);
> >  CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup);
> 
> This function is needed to instantiate clocks from DT overlays,
> which I'm using with out-of-tree "clk: add generic driver for fixed rate clock".
> 

I think Ricardo's latest series should make that work for you
with platform device drivers?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project