linux-kernel - Re: [PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3622395.gCDXC5WShC@vostro.rjw.lan>
Date:	Tue, 16 Aug 2016 22:47:16 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
	Sudeep Holla <sudeep.holla@....com>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] cpufreq-SCPI: Delete unnecessary assignment for the field "owner"

On Tuesday, August 16, 2016 10:38:02 PM SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 16 Aug 2016 22:30:17 +0200
> 
> The field "owner" is set by the core.
> Thus delete an unneeded initialisation.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/cpufreq/scpi-cpufreq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
> index e8a7bf5..4a70d241 100644
> --- a/drivers/cpufreq/scpi-cpufreq.c
> +++ b/drivers/cpufreq/scpi-cpufreq.c
> @@ -104,8 +104,7 @@ static int scpi_cpufreq_remove(struct platform_device *pdev)
>  
>  static struct platform_driver scpi_cpufreq_platdrv = {
>  	.driver = {
> -		.name	= "scpi-cpufreq",
> -		.owner	= THIS_MODULE,
> +		.name	= "scpi-cpufreq"

Comma, please.

>  	},
>  	.probe		= scpi_cpufreq_probe,
>  	.remove		= scpi_cpufreq_remove,
> 

Thanks.
Rafael