linux-kernel - Re: [RESEND PATCH] [media] vb2: Fix vb2_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160817090144.GD3182@valkosipuli.retiisi.org.uk>
Date:	Wed, 17 Aug 2016 12:01:44 +0300
From:	Sakari Ailus <sakari.ailus@....fi>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, Hans Verkuil <hverkuil@...all.nl>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Pawel Osciak <pawel@...iak.com>, linux-media@...r.kernel.org
Subject: Re: [RESEND PATCH] [media] vb2: Fix vb2_core_dqbuf() kernel-doc

Hi Javier,

On Tue, Aug 16, 2016 at 10:20:16AM -0400, Javier Martinez Canillas wrote:
> The kernel-doc has the wrong function name and also the pindex
> parameter is missing in the documentation.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> 
> ---
> 
> This patch was posted some weeks ago but I noticed that wasn't
> picked by patchwork, so I'm resend it.
> 
>  drivers/media/v4l2-core/videobuf2-core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> index ca8ffeb56d72..1dbd7beb71f0 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -1726,8 +1726,9 @@ static void __vb2_dqbuf(struct vb2_buffer *vb)
>  }
>  
>  /**
> - * vb2_dqbuf() - Dequeue a buffer to the userspace
> + * vb2_core_dqbuf() - Dequeue a buffer to the userspace
>   * @q:		videobuf2 queue
> + * @pindex:	id number of the buffer

How about: "Pointer to the buffer index. May be NULL.".

Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

>   * @pb:		buffer structure passed from userspace to vidioc_dqbuf handler
>   *		in driver
>   * @nonblocking: if true, this call will not sleep waiting for a buffer if no

-- 
Cheers,

Sakari Ailus
e-mail: sakari.ailus@....fi	XMPP: sailus@...iisi.org.uk