[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aeec6ee5-91e9-13fa-f7fa-09581ddb9b6a@ti.com>
Date: Wed, 17 Aug 2016 15:24:42 +0530
From: Sekhar Nori <nsekhar@...com>
To: Karl Beldan <kbeldan@...libre.com>, <devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
CC: <linux-kernel@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Russell King <linux@...linux.org.uk>,
Kevin Hilman <khilman@...libre.com>,
Karl Beldan <karl.beldan+oss@...il.com>,
Peter Ujfalusi <peter.ujfalusi@...com>
Subject: Re: [PATCH 1/2] ARM: dts: da850-lcdk: Audio support via simple-card
On Thursday 11 August 2016 01:38 AM, Karl Beldan wrote:
> The LCDK embeds a TLV320AIC3106 connected to the SoC McASP for analog
> audio. This relies on the 'dummy' regulator as the codec is always on.
> Quality is good with arecord -pipe- aplay on Line In/Line Out.
> The MIC path doesn't seem to work yet.
I tested the patch and I could not get the MIC to work as well. I
suggest dropping the MIC path parts till that is debugged and root caused.
> Signed-off-by: Karl Beldan <kbeldan@...libre.com>
> ---
> arch/arm/boot/dts/da850-lcdk.dts | 75 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 75 insertions(+)
> +&i2c0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_pins>;
> + clock-frequency = <100000>;
> + status = "okay";
> +
> + tlv320aic3106: tlv320aic3106@18 {
> + #sound-dai-cells = <0>;
> + compatible = "ti,tlv320aic3106";
> + reg = <0x18>;
> + status = "okay";
> +
> + ai3x-micbias-vg = <MICBIAS_2_5V>;
It will be nice to add the codec regulators as well (and that in turn
needs the PMIC to be populated). Although I wont insist on that since
the regulators are optional properties.
Rest of the patch looks good to me.
Thanks,
Sekhar
Powered by blists - more mailing lists