linux-kernel - Re: [PATCH v3 1/3] sas: provide stub implementation for scsi_is_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201608171706.iwWe0sTm%fengguang.wu@intel.com>
Date:	Wed, 17 Aug 2016 17:56:47 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Johannes Thumshirn <jthumshirn@...e.de>
Cc:	kbuild-all@...org, James Bottomley <jejb@...ux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@...cle.com>,
	Hannes Reinecke <hare@...e.de>,
	Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
	Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
	Johannes Thumshirn <jthumshirn@...e.de>
Subject: Re: [PATCH v3 1/3] sas: provide stub implementation for
 scsi_is_sas_rphy

Hi Johannes,

[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.8-rc2 next-20160817]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Johannes-Thumshirn/Fix-panic-when-a-SES-device-is-attached-to-a-hpsa-logical-volume/20160817-165528
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: i386-randconfig-x009-201633 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/init.h:4:0,
                    from drivers/scsi/scsi_transport_sas.c:26:
   drivers/scsi/scsi_transport_sas.c: In function 'do_sas_phy_delete':
   drivers/scsi/scsi_transport_sas.c:338:24: error: implicit declaration of function 'scsi_is_sas_phy' [-Werror=implicit-function-declaration]
     else if (pass == 1 && scsi_is_sas_phy(dev))
                           ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/scsi/scsi_transport_sas.c:338:7: note: in expansion of macro 'if'
     else if (pass == 1 && scsi_is_sas_phy(dev))
          ^~
   cc1: some warnings being treated as errors

vim +/if +338 drivers/scsi/scsi_transport_sas.c

c7ebbbce Christoph Hellwig 2005-09-09  322  	if (!shost->transportt)
c7ebbbce Christoph Hellwig 2005-09-09  323  		return 0;
c7ebbbce Christoph Hellwig 2005-09-09  324  	if (shost->transportt->host_attrs.ac.class !=
c7ebbbce Christoph Hellwig 2005-09-09  325  			&sas_host_class.class)
c7ebbbce Christoph Hellwig 2005-09-09  326  		return 0;
c7ebbbce Christoph Hellwig 2005-09-09  327  
c7ebbbce Christoph Hellwig 2005-09-09  328  	i = to_sas_internal(shost->transportt);
c7ebbbce Christoph Hellwig 2005-09-09  329  	return &i->t.host_attrs.ac == cont;
c7ebbbce Christoph Hellwig 2005-09-09  330  }
c7ebbbce Christoph Hellwig 2005-09-09  331  
c7ebbbce Christoph Hellwig 2005-09-09  332  static int do_sas_phy_delete(struct device *dev, void *data)
c7ebbbce Christoph Hellwig 2005-09-09  333  {
65c92b09 James Bottomley   2006-06-28  334  	int pass = (int)(unsigned long)data;
65c92b09 James Bottomley   2006-06-28  335  
65c92b09 James Bottomley   2006-06-28  336  	if (pass == 0 && scsi_is_sas_port(dev))
65c92b09 James Bottomley   2006-06-28  337  		sas_port_delete(dev_to_sas_port(dev));
65c92b09 James Bottomley   2006-06-28 @338  	else if (pass == 1 && scsi_is_sas_phy(dev))
c7ebbbce Christoph Hellwig 2005-09-09  339  		sas_phy_delete(dev_to_phy(dev));
c7ebbbce Christoph Hellwig 2005-09-09  340  	return 0;
c7ebbbce Christoph Hellwig 2005-09-09  341  }
c7ebbbce Christoph Hellwig 2005-09-09  342  
c7ebbbce Christoph Hellwig 2005-09-09  343  /**
3b91d09c James Bottomley   2015-12-09  344   * is_sas_attached - check if device is SAS attached
3b91d09c James Bottomley   2015-12-09  345   * @sdev: scsi device to check
3b91d09c James Bottomley   2015-12-09  346   *

:::::: The code at line 338 was first introduced by commit
:::::: 65c92b09acf0218b64f1c7ba4fdabeb8b732c876 [SCSI] scsi_transport_sas: introduce a sas_port entity

:::::: TO: James Bottomley <James.Bottomley@...eleye.com>
:::::: CC: James Bottomley <jejb@...grave.il.steeleye.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (27190 bytes)