linux-kernel - Re: [PATCH] ARM: dts: exynos: Use stdout non-deprecated property and add serial options to Odroid XU/XU3/XU4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <bae50bce-8e56-62cc-89b4-68532c2acaf0@samsung.com>
Date:	Wed, 17 Aug 2016 12:28:48 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Mark Rutland <mark.rutland@....com>
Cc:	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH] ARM: dts: exynos: Use stdout non-deprecated property and
 add serial options to Odroid XU/XU3/XU4

On 08/17/2016 12:25 PM, Mark Rutland wrote:
> On Wed, Aug 17, 2016 at 09:34:58AM +0200, Krzysztof Kozlowski wrote:
>> The "linux,stdout-path" is deprecated.
>>
>> Add serial options so the console can be properly configured when
>> bootloader does not pass "console" parameter to command line.  Without
>> options and lack of "console", the serial output dies during boot (just
>> after probing sound).
> 
> I'm confused. Is this just a cleanup (given "linux,stdout-path" is
> deprecated but still supported), or a bug fix?

There is no bug, so rather this is cleanup and improvement in one.
Usually we pass full console=ttySAC2,115200n8 from UBoot to command
line. The usage of serial options allows skipping that.

I can split the cleanup part from improvement. To me it looked a little
bit too much but I don't mind.

> I guess that prior to this patch Linux might change the rate of the
> console, but otherwise it should work.

It still can be overridden by command line if needed.

Best regards,
Krzysztof