linux-kernel - Re: [PACTH v3] mmc: sdhci: Do not allow tuning procedure to be interrupted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eee256ca-3366-b25c-0936-0a80b1510325@intel.com>
Date:	Wed, 17 Aug 2016 13:47:33 +0300
From:	Adrian Hunter <adrian.hunter@...el.com>
To:	robert.foss@...labora.com, ulf.hansson@...aro.org,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Bresticker <abrestic@...omium.org>,
	Kevin Cernekee <cernekee@...omium.org>,
	Benson Leung <bleung@...omium.org>
Cc:	Christopher Freeman <cfreeman@...dia.com>
Subject: Re: [PACTH v3] mmc: sdhci: Do not allow tuning procedure to be
 interrupted

On 17/08/16 00:25, robert.foss@...labora.com wrote:
> From: Christopher Freeman <cfreeman@...dia.com>
> 
> wait_event_interruptible_timeout() will return early if the blocked
> process receives a signal, causing the driver to abort the tuning
> procedure and possibly leaving the controller in a bad state.  Since the
> tuning command is expected to complete quickly (<50ms) and we've set a
> timeout, use wait_event_timeout() instead.
> 
> Signed-off-by: Christopher Freeman <cfreeman@...dia.com>
> Tested-by: Robert Foss <robert.foss@...labora.com>
> Signed-off-by: Robert Foss <robert.foss@...labora.com>
> Reviewed-by: Benson Leung <bleung@...omium.org>

The mmc block queues are kernel threads which I would expect ignore signals,
so I am curious how you hit this?

In any case:

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 0e3d7c0..9e80203 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1960,7 +1960,7 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
>  
>  		spin_unlock_irqrestore(&host->lock, flags);
>  		/* Wait for Buffer Read Ready interrupt */
> -		wait_event_interruptible_timeout(host->buf_ready_int,
> +		wait_event_timeout(host->buf_ready_int,
>  					(host->tuning_done == 1),
>  					msecs_to_jiffies(50));
>  		spin_lock_irqsave(&host->lock, flags);
>