linux-kernel - [BISECTED REGRESSION] v4.8-rc: DT/OCTEON driver probing broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160816150056.GD18731@ak-desktop.emea.nsn-net.net>
Date:	Tue, 16 Aug 2016 18:00:57 +0300
From:	Aaro Koskinen <aaro.koskinen@...ia.com>
To:	Kefeng Wang <wangkefeng.wang@...wei.com>,
	Rob Herring <robh@...nel.org>, <devicetree@...r.kernel.org>,
	<linux-mips@...ux-mips.org>, Ralf Baechle <ralf@...ux-mips.org>,
	David Daney <david.daney@...ium.com>
CC:	<linux-kernel@...r.kernel.org>,
	Thorsten Leemhuis <regressions@...mhuis.info>
Subject: [BISECTED REGRESSION] v4.8-rc: DT/OCTEON driver probing broken

Hi,

Commit 44a7185c2ae6 ("of/platform: Add common method to populate default
bus") added new arch_initcall of_platform_default_populate_init() that
will be called before device_initcall octeon_publish_devices(). Now the
of_platform_bus_probe() called in octeon_publish_devices() is apparently
doing nothing:

[   52.331353] calling  octeon_publish_devices+0x0/0x14 @ 1
[   52.331358] OF: of_platform_bus_probe()
[   52.331362] OF:  starting at: /
[   52.331378] OF: of_platform_bus_create() - skipping /soc@0, already populated
[   52.331394] initcall octeon_publish_devices+0x0/0x14 returned 0 after 29 usecs

This also means that USB etc. won't get probed.

Any ideas what would be the proper fix for this? Changing
octeon_publish_devices() to arch_initcall seems to work but that may be
a bit hackish... Also, there might be also other MIPS boards affected
(arch/mips/netlogic/xlp/dt.c, arch/mips/mti-malta/malta-dt.c).

A.