linux-kernel - Re: [PATCH] ARC: Change ld.as instruction to regular ld.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fceb8e24-0c94-a84d-5ed8-7fbe33f369d4@synopsys.com>
Date:	Wed, 17 Aug 2016 10:16:44 -0700
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Liav Rehana <liavr@...lanox.com>
CC:	"noamca@...lanox.com" <noamca@...lanox.com>,
	"linux-snps-arc@...ts.infradead.org" 
	<linux-snps-arc@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"eladkan@...lanox.com" <eladkan@...lanox.com>
Subject: Re: [PATCH] ARC: Change ld.as instruction to regular ld.

On 08/16/2016 11:24 PM, Liav Rehana wrote:
> From: Liav Rehana <liavr@...lanox.com>
>
> User mode callee regs are explicitly collected before signal delivery
> or breakpoint trap. r25 is special for kernel as it serves as task
> pointer, so user mode value is clobbered very early. It is saved in
> pt_regs where generally only scratch (caller saved) res are saved.
> The code to access the corresponding pt_regs location had a subtle bug
> as it was using load/store with scaling of offset, whereas the offset
> was already byte wise correct. So fix this by replacing LD.AS with a
> standard LD
>
> Signed-off-by: Liav Rehana <liavr@...lanox.com>

Thx for the fix Liv.
I added it to my for-curr.

-Vineet