[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160817002319.GB81374@f23x64.localdomain>
Date: Tue, 16 Aug 2016 17:23:19 -0700
From: Darren Hart <dvhart@...radead.org>
To: Paul Gortmaker <paul.gortmaker@...driver.com>
Cc: linux-kernel@...r.kernel.org, Alek Du <alek.du@...el.com>,
platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] platform: intel_pmic: make gpio explicitly non-modular
On Mon, Aug 15, 2016 at 06:24:59PM -0400, Paul Gortmaker wrote:
> The Kconfig entry controlling compilation of this code is:
>
> drivers/platform/x86/Kconfig:config GPIO_INTEL_PMIC
> drivers/platform/x86/Kconfig: bool "Intel PMIC GPIO support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> We don't replace module.h with init.h since the file already has that.
>
> Cc: Darren Hart <dvhart@...radead.org>
> Cc: Alek Du <alek.du@...el.com>
> Cc: platform-driver-x86@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
Queued to fixes for 4.8, thank you.
--
Darren Hart
Intel Open Source Technology Center
Powered by blists - more mailing lists