linux-kernel - Re: [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOw6vbLi+T+-JHgKR78GAhck=P+1fT90AKW0C9OBJ+tX5Sm5mQ@mail.gmail.com>
Date:	Wed, 17 Aug 2016 14:21:28 -0700
From:	Sean Paul <seanpaul@...omium.org>
To:	Brian Norris <briannorris@...omium.org>
Cc:	Mark Yao <mark.yao@...k-chips.com>,
	David Airlie <airlied@...ux.ie>,
	Heiko Stuebner <heiko@...ech.de>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	linux-rockchip@...ts.infradead.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Yakir Yang <ykk@...k-chips.com>
Subject: Re: [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe
 deferral "error" print

On Wed, Aug 17, 2016 at 2:10 PM, Brian Norris <briannorris@...omium.org> wrote:
> This driver is the only user of of_drm_find_panel() which prints an
> error before doing probe deferral, yielding messages like this on boot,
> before eventually succeeding:
>
> [    2.234271] [drm:rockchip_dp_probe] *ERROR* failed to find panel
> ...
> [    4.797539] [drm:rockchip_dp_probe] *ERROR* failed to find panel
> ...
>
> Let's just drop the message.
>
> Signed-off-by: Brian Norris <briannorris@...omium.org>


Looks good. I'll add this to the rest of the rockchip patches I have
queued for -next.

Reviewed-by: Sean Paul <seanpaul@...omium.org>


> ---
>  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index 89aadbf465f8..045fcc46827c 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -381,10 +381,8 @@ static int rockchip_dp_probe(struct platform_device *pdev)
>
>                 panel = of_drm_find_panel(panel_node);
>                 of_node_put(panel_node);
> -               if (!panel) {
> -                       DRM_ERROR("failed to find panel\n");
> +               if (!panel)
>                         return -EPROBE_DEFER;
> -               }
>         }
>
>         dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);
> --
> 2.8.0.rc3.226.g39d4020
>