linux-kernel - Re: [PATCH] net: ipconfig: Fix more use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160817.193426.2273185535811000291.davem@davemloft.net>
Date:	Wed, 17 Aug 2016 19:34:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	thierry.reding@...il.com
Cc:	u.kleine-koenig@...gutronix.de, geert+renesas@...der.be,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ipconfig: Fix more use after free

From: Thierry Reding <thierry.reding@...il.com>
Date: Tue, 16 Aug 2016 16:45:38 +0200

> From: Thierry Reding <treding@...dia.com>
> 
> While commit 9c706a49d660 ("net: ipconfig: fix use after free") avoids
> the use after free, the resulting code still ends up calling both the
> ic_setup_if() and ic_setup_routes() after calling ic_close_devs(), and
> access to the device is still required.
> 
> Move the call to ic_close_devs() to the very end of the function.
> 
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
> This applies on top of next-20160816.

Applied, thanks.