linux-kernel - Re: [PATCH v3 2/5] net: ethernet: ti: davinci_cpdma: fix locking while ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ea7e2ef-2677-91e9-63f5-c12b58fa3287@ti.com>
Date:	Wed, 17 Aug 2016 11:12:25 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<grygorii.strashko@...com>
CC:	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<nsekhar@...com>
Subject: Re: [PATCH v3 2/5] net: ethernet: ti: davinci_cpdma: fix locking
 while ctrl_stop

On Tuesday 16 August 2016 04:55 AM, Ivan Khoronzhuk wrote:
> The interrupts shouldn't be disabled while receiving skb, but while
> ctrl_stop, the channels are stopped and all remaining packets are
> handled with netif_receive_skb():
> 
> lock_irq_save
>     cpdma_ctlr_stop
>        cpdma_chan_top
>            __cpdma_chan_free
>                cpsw_rx_handler
>                    netif_receive_skb
> 
> So, split locking while ctrl stop thus interrupts are still
> enabled while skbs handling. It can cause WARN_ONCE in rare
> cases when ctrl is stopping while not all packets were handled
> with NAPIs.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>

Reviewed-by: Mugunthan V N <mugunthanvnm@...com>

Regards
Mugunthan V N