linux-kernel - Re: [PATCH v2] clk: max77686: Migrate to clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <ab7f86c8-8feb-1512-2046-016b950ce68b@samsung.com>
Date:	Wed, 17 Aug 2016 08:05:03 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Stephen Boyd <stephen.boyd@...aro.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
	Javier Martinez Canillas <javier@....samsung.com>,
	Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH v2] clk: max77686: Migrate to clk_hw based OF and
 registration APIs

On 08/17/2016 12:38 AM, Stephen Boyd wrote:
> Now that we have clk_hw based provider APIs to register clks, we
> can get rid of struct clk pointers while registering clks in
> these drivers, allowing us to move closer to a clear split of
> consumer and provider clk APIs.
> 
> Cc: Javier Martinez Canillas <javier@....samsung.com>
> Cc: Laxman Dewangan <ldewangan@...dia.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Signed-off-by: Stephen Boyd <stephen.boyd@...aro.org>
> ---
>  drivers/clk/clk-max77686.c | 42 +++++++++++++++++++++---------------------
>  1 file changed, 21 insertions(+), 21 deletions(-)

Looks correct. The pr_err() could be replaced to dev_err() but first
pointer to dev should be stored... so this may be fixed on different patch.

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Best regards,
Krzysztof