linux-kernel - Re: [PATCH 1/4] usb: host: xhci: Move the xhci quirks checking to the right place

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lgzu5yx4.fsf@linux.intel.com>
Date:	Thu, 18 Aug 2016 10:17:11 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	Baolin Wang <baolin.wang@...aro.org>, gregkh@...uxfoundation.org,
	mathias.nyman@...ux.intel.com
Cc:	mathias.nyman@...el.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, broonie@...nel.org,
	baolin.wang@...aro.org
Subject: Re: [PATCH 1/4] usb: host: xhci: Move the xhci quirks checking to the right place


Hi,

Baolin Wang <baolin.wang@...aro.org> writes:
> It will reset the xhci quirks in xhci_gen_setup() function when xhci try to
> add one hcd, thus we need to move the XHCI_LPM_SUPPORT quirk checking after
> adding hcd.
>
> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
> ---
>  drivers/usb/host/xhci-plat.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 1f3f981..e2e2487 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -223,10 +223,6 @@ static int xhci_plat_probe(struct platform_device *pdev)
>  		goto disable_clk;
>  	}
>  
> -	if ((node && of_property_read_bool(node, "usb3-lpm-capable")) ||
> -			(pdata && pdata->usb3_lpm_capable))
> -		xhci->quirks |= XHCI_LPM_SUPPORT;
> -
>  	if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
>  		xhci->shared_hcd->can_do_streams = 1;
>  
> @@ -250,6 +246,10 @@ static int xhci_plat_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto dealloc_usb2_hcd;
>  
> +	if ((node && of_property_read_bool(node, "usb3-lpm-capable")) ||
> +			(pdata && pdata->usb3_lpm_capable))
> +		xhci->quirks |= XHCI_LPM_SUPPORT;
> +

Mathias, any comments here?

>  	return 0;
>  
>  
> -- 
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (801 bytes)