linux-kernel - Re: [RESEND PATCH 1/1] bitops.h: move out get_count_order[_long]() from __KERNEL_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09babb60-f7fa-9c5a-8afd-f0cf31a9f785@zoho.com>
Date:	Thu, 18 Aug 2016 08:50:37 +0800
From:	zijun_hu <zijun_hu@...o.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH 1/1] bitops.h: move out get_count_order[_long]()
 from __KERNEL__ scope

On 2016/8/18 8:28, Al Viro wrote:
> On Thu, Aug 18, 2016 at 08:10:19AM +0800, zijun_hu wrote:
> 
>> Documentation/kbuild/makefiles.txt：
>> The kernel includes a set of headers that is exported to userspace.
>> Many headers can be exported as-is but other headers require a
>> minimal pre-processing before they are ready for user-space.
>> The pre-processing does:
>> - drop kernel-specific annotations
>> - drop include of compiler.h
>> - drop all sections that are kernel internal (guarded by ifdef __KERNEL__)
>>
>> scripts/Makefile.headersinst:
>> # ==========================================================================
>> # Installing headers
>> #
>> # header-y  - list files to be installed. They are preprocessed
>> #             to remove __KERNEL__ section of the file
>> # genhdr-y  - Same as header-y but in a generated/ directory
> 
> Quite.  Now, could you show me where bitops.h is mentioned in any header-y
> assignments?
> 
you are right bitops.h isn't mentioned in any header-y
my aim is making macro __KERNEL__ purpose or history purpose clear
it isn't a bad thing to follow __KERNEL__ purpose
it maybe look nicer to keep get_counter_order() original scope 

that don't matter since the current scope works well also
> Stuff outside of */uapi/* is not exported at all.
>