linux-kernel - Re: [PATCH] mmc: sdhci-brcmstb: Delete owner assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dff176a-b863-eccb-673f-52df6a4cbad0@intel.com>
Date:	Thu, 18 Aug 2016 15:41:07 +0300
From:	Adrian Hunter <adrian.hunter@...el.com>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	bcm-kernel-feedback-list@...adcom.com,
	linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org,
	Al Cooper <alcooperx@...il.com>,
	Brian Norris <computersforpeace@...il.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Gregory Fong <gregory.0xf0@...il.com>,
	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] mmc: sdhci-brcmstb: Delete owner assignment

On 15/08/16 08:40, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 15 Aug 2016 07:32:45 +0200
> 
> The field "owner" is set by core. Thus delete an extra initialisation.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Could insert a blank line here

> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Otherwise:

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci-brcmstb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index cce10fe..609ba5b 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -128,7 +128,6 @@ MODULE_DEVICE_TABLE(of, sdhci_brcm_of_match);
>  static struct platform_driver sdhci_brcmstb_driver = {
>  	.driver		= {
>  		.name	= "sdhci-brcmstb",
> -		.owner	= THIS_MODULE,
>  		.pm	= &sdhci_brcmstb_pmops,
>  		.of_match_table = of_match_ptr(sdhci_brcm_of_match),
>  	},
>