linux-kernel - Re: [PATCH v9 4/4] arm64: dts: rockchip: configure usb2-phy support for rk3399-evb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4752a1d7-9db9-bfe9-1544-f90f33d4f560@rock-chips.com>
Date:	Thu, 18 Aug 2016 10:53:22 +0800
From:	Frank Wang <frank.wang@...k-chips.com>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	dianders@...omium.org, linux@...ck-us.net, groeck@...omium.org,
	jwerner@...omium.org, kishon@...com, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	xzy.xu@...k-chips.com, kever.yang@...k-chips.com,
	huangtao@...k-chips.com, william.wu@...k-chips.com,
	daniel.meng@...k-chips.com
Subject: Re: [PATCH v9 4/4] arm64: dts: rockchip: configure usb2-phy support
 for rk3399-evb

On 2016/8/17 18:02, Heiko Stübner wrote:
> Am Freitag, 22. Juli 2016, 15:00:46 schrieb Frank Wang:
>> Add vcc5v0_host regulator for usb2-phy and enable host-port support.
>>
>> Signed-off-by: Frank Wang <frank.wang@...k-chips.com>
> applied to ny dts64 branch [0] with some changes:
>
> - the pin is named vcc5v0_host_en not host_vbus_drv in the schematics
>    please always try to use the names from the schematics
> - separated the enablement of the subnodes
>

Thanks for your valuable comments, I will try to improve the quality of 
my patches in future.

BR.
Frank

> Heiko
>
> [0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=1d3bc1d6c9c4658d554bcf89a71b35a6783a5b4e
>
>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3399-evb.dts |   44
>> +++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
>> b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts index 1a3eb14..56aeedb 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
>> @@ -69,6 +69,25 @@
>>   		regulator-max-microvolt = <3300000>;
>>   	};
>>
>> +	vcc5v0_sys: vcc5v0-sys {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vcc5v0_sys";
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +	};
>> +
>> +	vcc5v0_host: vcc5v0-host-regulator {
>> +		compatible = "regulator-fixed";
>> +		enable-active-high;
>> +		gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&host_vbus_drv>;
>> +		regulator-name = "vcc5v0_host";
>> +		vin-supply = <&vcc5v0_sys>;
>> +	};
>> +
>>   	vcc_phy: vcc-phy-regulator {
>>   		compatible = "regulator-fixed";
>>   		regulator-name = "vcc_phy";
>> @@ -89,6 +108,24 @@
>>   	status = "okay";
>>   };
>>
>> +&u2phy0 {
>> +	status = "okay";
>> +
>> +	u2phy0_host: host-port {
>> +		phy-supply = <&vcc5v0_host>;
>> +		status = "okay";
>> +	};
>> +};
>> +
>> +&u2phy1 {
>> +	status = "okay";
>> +
>> +	u2phy1_host: host-port {
>> +		phy-supply = <&vcc5v0_host>;
>> +		status = "okay";
>> +	};
>> +};
>> +
>>   &uart2 {
>>   	status = "okay";
>>   };
>> @@ -121,4 +158,11 @@
>>   				<1 18 RK_FUNC_GPIO &pcfg_pull_down>;
>>   		};
>>   	};
>> +
>> +	usb2 {
>> +		host_vbus_drv: host-vbus-drv {
>> +			rockchip,pins =
>> +				<4 25 RK_FUNC_GPIO &pcfg_pull_none>;
>> +		};
>> +	};
>>   };