linux-kernel - Re: [PATCH] proc, smaps: reduce printing overhead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Aug 2016 07:46:03 -0700
From:	Joe Perches <joe@...ches.com>
To:	Michal Hocko <mhocko@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	LKML <linux-kernel@...r.kernel.org>, Jann Horn <jann@...jh.net>
Subject: Re: [PATCH] proc, smaps: reduce printing overhead

On Thu, 2016-08-18 at 16:41 +0200, Michal Hocko wrote:
> On Thu 18-08-16 16:26:16, Michal Hocko wrote:
> > b) doesn't it try to be overly clever when doing that in the caller
> > doesn't cost all that much? Sure you can save few bytes in the spaces
> > but then I would just argue to use \t rather than fixed string length.
> ohh, I misread the code. It tries to emulate the width formater. But is
> this really necessary? Do we know about any tools doing a fixed string
> parsing?

I don't, but it's proc and all the output formatting
shouldn't be changed.

Appended to is generally OK, but whitespace changed is
not good.