linux-kernel - Re: [PATCH v5 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wpje60xu.fsf@linux.intel.com>
Date:	Thu, 18 Aug 2016 09:33:33 +0300
From:	Felipe Balbi <felipe.balbi@...ux.intel.com>
To:	Peter Chen <hzpeterchen@...il.com>
Cc:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Oliver Neukum <oneukum@...e.com>, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v5 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY


Hi,

Peter Chen <hzpeterchen@...il.com> writes:
> On Wed, Aug 17, 2016 at 03:53:24PM +0300, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Heikki Krogerus <heikki.krogerus@...ux.intel.com> writes:
>> 
>> [...]
>> 
>> > +static struct platform_driver wcove_typec_driver = {
>> > +	.driver = {
>> > +		.name		= "bxt_wcove_usbc",
>> > +	},
>> > +	.probe			= wcove_typec_probe,
>> > +	.remove			= wcove_typec_remove,
>> > +};
>> > +
>> > +module_platform_driver(wcove_typec_driver);
>> > +
>> > +MODULE_AUTHOR("Intel Corporation");
>> > +MODULE_LICENSE("GPL v2");
>> > +MODULE_DESCRIPTION("WhiskeyCove PMIC USB Type-C PHY driver");
>> 
>> you need to add:
>> 
>> MODULE_ALIAS("platform:bxt_wcove_usbc");
>> 
>> otherwise this won't probe() automagically.
>> 
>
> What do you mean, Felipe? If there is a platform device named
> "bxt_wcove_usbc", why it will not be probed?

IIRC default module alias is added based on file name, not
platform_driver name, so this would be
MODULE_ALIAS("platform:typec_wcove") by default... I could be wrong,
really don't remember the details of  that now.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (801 bytes)