linux-kernel - Re: [PART2 PATCH v5 12/12] svm: Implements update_pi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a230960-6e69-a513-cd27-b2919903be2d@amd.com>
Date:   Thu, 18 Aug 2016 22:43:30 +0700
From:   Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:     Radim Krčmář <rkrcmar@...hat.com>
CC:     <joro@...tes.org>, <pbonzini@...hat.com>,
        <alex.williamson@...hat.com>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <sherry.hurwitz@....com>
Subject: Re: [PART2 PATCH v5 12/12] svm: Implements update_pi_irte hook to
 setup posted interrupt

Hi Radim,

On 8/16/16 23:33, Radim Krčmář wrote:
>>> Maybe I was a bit confused by reusing amd_iommu_pi_data when all we care
>>> >> about is a list of cur->ir_data -- can't we have a list of just ir_data?
>> >
>> > Actually, in SVM, we care about posted-interrupt information, which is
>> > generated from the SVM side, and stored in the amd_iommu_pi_data. This is
>> > also communicated to IOMMU via the irq_set_vcpu_affinity().
>> >
>> > Here, I only use ir_data to differentiate amd_iommu_pi_data.
> I'm still confused then. :)
>
> struct amd_iommu_pi_data is a throwaway structure for I/O with
> irq_set_vcpu_affinity(), but we keep it afterwards ...
> is it more than a wrapper that allows us to put ir_data into a list,
> because we don't want to add list_head directly to ir_data?

Hm... I see you point now. I'll change it to ir_data list.

Thanks,
Suraveee