linux-kernel - Re: [PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare Spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160818194443.GX26240@tuxbot>
Date:   Thu, 18 Aug 2016 12:44:43 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Corentin LABBE <clabbe.montjoie@...il.com>
Cc:     ohad@...ery.com, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com
Subject: Re: [PATCH RFC 1/3] hwspinlock: sun8i: add Allwinner sun8i HardWare
 Spinlock

On Thu 18 Aug 12:38 PDT 2016, Corentin LABBE wrote:

> Hello
> 
> Thanks for your review, I will fix all your reports for next version.
> 
> On 12/08/2016 21:06, Bjorn Andersson wrote:
> > On Fri 12 Aug 04:46 PDT 2016, LABBE Corentin wrote:
> > 
> >> Add hwspinlock support for the Allwinner Hardware Spinlock device
> >> present on the A83T, H3 and A64 SoCs.
> >>
> >> This Hardware Spinlock device provides hardware assistance
> >> for synchronization between the multiple processors in the system.
> >>
> > [..]
> >> +		goto clk_fail;
> >> +	}
> >> +
> >> +	dev_info(&pdev->dev, "Sun8i hwspinlock driver loaded with %d locks\n",
> >> +		 priv->num_locks);
> > 
> > Please don't advertise the driver on success.
> > 
> 
> I was doing that because datasheet specify only 32 slot, but later a register give a possibility of more slots.
> Perhaps its better to advertise only for uncommon hardware (slot > 32) ?
> 

I see, well that would be useful for developers to see, how about you
just make it dev_dbg? That way one would be a command line addition [1]
away from getting the information out.

[1] dyndbg="module sun8i_hwspinlock +p"

Regards,
Bjorn