linux-kernel - Re: Question: Outer NMI can nest if from user mode?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2016 11:48:45 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Andy Lutomirski <luto@...capital.net>
Cc:     LKML <linux-kernel@...r.kernel.org>, Jiri Olsa <jolsa@...hat.com>
Subject: Re: Question: Outer NMI can nest if from user mode?

On Thu, 18 Aug 2016 11:21:55 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> Hi Andy,
> 
> I was reading some of the comments in nmi.c and came across this:
> 
> /*
>  * NMIs can page fault or hit breakpoints which will cause it to lose
>  * its NMI context with the CPU when the breakpoint or page fault does an IRET.
>  *
>  * As a result, NMIs can nest if NMIs get unmasked due an IRET during
>  * NMI processing.  On x86_64, the asm glue protects us from nested NMIs
>  * if the outer NMI came from kernel mode, but we can still nest if the
>  * outer NMI came from user mode.
> 
> 
> What confuses me is "but we can still nest if the outer NMI came from
> user mode".
> 
> How can that happen? You mean do_nmi() can be called nested even on
> x86_64 if the first NMI happened in user mode?

Never mind. Jiri pointed out this patch (which I forgot about :-p)

9b6e6a8334d56 x86/nmi/64: Switch stacks on userspace NMI entry

Which switches the stack to the kernel stack from the NMI stack if we
came from user mode. That explains how the asm glue wont catch it.

-- Steve