linux-kernel - Re: [PATCH v2] libnvdimm: Fix nvdimm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Aug 2016 10:17:38 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Toshi Kani <toshi.kani@....com>
Cc:     dan.j.williams@...el.com, linux-kernel@...r.kernel.org,
        linux-nvdimm@...ts.01.org
Subject: Re: [PATCH v2] libnvdimm: Fix nvdimm_probe error on NVDIMM-N

On Tue, Aug 16, 2016 at 01:08:40PM -0600, Toshi Kani wrote:
> 'ndctl list --buses --dimms' does not list any NVDIMM-Ns since
> they are considered as idle.  ndctl checks if any driver is
> attached to nmem device.  nvdimm_probe() always fails in
> nvdimm_init_nsarea() since NVDIMM-Ns do not implement optinal
> ND_CMD_GET_CONFIG_DATA command.
> 
> Change nvdimm_probe() to accept the case that the CONFIG_DATA
> command is not implemented for NVDIMM-Ns.  The driver attaches
> without ndd, which keeps it no-op to the device.
> 
> Reported-by: Brian Boylston <brian.boylston@....com>
> Signed-off-by: Toshi Kani <toshi.kani@....com>
> Cc: Dan Williams <dan.j.williams@...el.com>

Tested-by: Johannes Thumshirn <jthumshirn@...e.de>
Acked-by: Johannes Thumshirn <jthumshirn@...e.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850