linux-kernel - Re: [PATCH v7 1/4] mfd: RK808: Add RK818 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160819083336.GI4254@dell>
Date:   Fri, 19 Aug 2016 09:33:36 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Wadim Egorov <w.egorov@...tec.de>
Cc:     linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
        devicetree@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        dianders@...omium.org, zyw@...k-chips.com, robh+dt@...nel.org,
        mark.rutland@....com, lgirdwood@...il.com, broonie@...nel.org,
        a.zummo@...ertech.it, alexandre.belloni@...e-electrons.com
Subject: Re: [PATCH v7 1/4] mfd: RK808: Add RK818 support

On Fri, 19 Aug 2016, Wadim Egorov wrote:
> On 18.08.2016 16:34, Lee Jones wrote:
> > On Wed, 10 Aug 2016, Wadim Egorov wrote:
> >
> >> The RK818 chip is a Power Management IC (PMIC) for multimedia and handheld
> >> devices. It contains the following components:
> >>
> >> - Regulators
> >> - RTC
> >> - Clocking
> >> - Battery support
> >>
> >> Both RK808 and RK818 chips are using a similar register map,
> >> so we can reuse the RTC and Clocking functionality.
> >>
> >> Signed-off-by: Wadim Egorov <w.egorov@...tec.de>
> >> Tested-by: Andy Yan <andy.yan@...k-chips.com>
> >> ---
> >> Changes since v6:
> >> - Squashed in the patch
> >>   mfd: RK808: Fetch PMIC variant from chip id register
> >>
> >> ---
> >>  drivers/mfd/Kconfig       |   4 +-
> >>  drivers/mfd/rk808.c       | 226 +++++++++++++++++++++++++++++++++++++++-------
> >>  include/linux/mfd/rk808.h | 154 +++++++++++++++++++++++++++++--
> >>  3 files changed, 342 insertions(+), 42 deletions(-)

[...]

> >>  struct rk808_reg_data {
> >>  	int addr;
> >> @@ -57,6 +62,14 @@ static bool rk808_is_volatile_reg(struct device *dev, unsigned int reg)
> >>  	return false;
> >>  }
> >>  
> >> +static const struct regmap_config rk818_regmap_config = {
> >> +	.reg_bits = 8,
> >> +	.val_bits = 8,
> >> +	.max_register = RK818_USB_CTRL_REG,
> >> +	.cache_type = REGCACHE_RBTREE,
> >> +	.volatile_reg = rk808_is_volatile_reg,
> >> +};
> >> +
> >>  static const struct regmap_config rk808_regmap_config = {
> >>  	.reg_bits = 8,
> >>  	.val_bits = 8,
> >> @@ -79,11 +92,21 @@ static const struct mfd_cell rk808s[] = {
> >>  	{
> >>  		.name = "rk808-rtc",
> >>  		.num_resources = ARRAY_SIZE(rtc_resources),
> >> -		.resources = &rtc_resources[0],
> >> +		.resources = rtc_resources,
> > ?
> 
> you told me to change this

It's an unrelated change that has nothing to do with this patch, which
is why I am confused.

But it's okay, I'll let it sneak in on this occasion, rather than
asking you to send a separate patch.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog