linux-kernel - Re: [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Aug 2016 12:54:28 +0300
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     Russell King - ARM Linux <linux@...linux.org.uk>
CC:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        Tony Lindgren <tony@...mide.com>, <misael.lopez@...com>
Subject: Re: [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device
 registration

On 08/19/16 11:54, Russell King - ARM Linux wrote:
> On Fri, Aug 19, 2016 at 09:34:24AM +0300, Peter Ujfalusi wrote:
>> The dmic-codec was registered within the platform_driver's probe function,
>> which can cause deferred probe to run in loops as reported and analyzed by
>> Russell King.
>>
>> Use module_init/exit in the driver and handle the dmic-codec device
>> registration and removal at that level instead of the platform_driver
>> probe/remove.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
>> Reported-by: Russell King <linux@....linux.org.uk>
> 
> I think this address came from memory... it's certainly not the one that
> I'm using today. ;)

I'm really sorry. I have one txt file where I store e-mail addresses when I'm
lazy to look them up in my mailbox. txt updated.

Mark: can you fix Russell's e-mail addrress to:
linux@...linux.org.uk

Or I can resend the patch.

> 
>> ---
> 
> This certainly fixes the problem:
> 
> VUSB: disabling
> mmcblk0: mmc0:0002 00000 972 MiB
> ALSA device list:
>  mmcblk0: p1 p2
>   No soundcards found.
> omap-abe-twl6040 sound: ASoC: CPU DAI (null) not registered
> omap-abe-twl6040 sound: snd_soc_register_card() failed: -517
> Waiting 2 sec before mounting root device...
> EXT4-fs (mmcblk0p2): mounting ext3 file system using the ext4 subsystem
> EXT4-fs (mmcblk0p2): warning: maximal mount count reached, running e2fsck is recommended
> 
> and allows booting to continue.  Thanks.
> 
> Tested-by: Russell King <rmk+kernel@...linux.org.uk>
> 


-- 
Péter