linux-kernel - Re: [PATCH] PM / Domains: Always enable debugfs support if available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Aug 2016 13:32:51 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Jon Hunter <jonathanh@...dia.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Kevin Hilman <khilman@...nel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM / Domains: Always enable debugfs support if available

On 11 August 2016 at 12:40, Jon Hunter <jonathanh@...dia.com> wrote:
> Debugfs support for PM domains is only enabled if both CONFIG_PM_DEBUG
> and CONFIG_PM_ADVANCED_DEBUG are enabled. CONFIG_PM_ADVANCED_DEBUG is
> described as "extra PM attributes in sysfs for low-level
> debugging/testing" which does not seem related.
>
> Given that the debugfs for PM domains only allows users to view the
> state of the PM domains, always enable debugfs support for PM domains
> if PM domains and debugfs support is enabled.
>
> Signed-off-by: Jon Hunter <jonathanh@...dia.com>

Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe

> ---
>  drivers/base/power/domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index a1f2aff33997..058c8b6d2871 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1636,7 +1636,7 @@ EXPORT_SYMBOL_GPL(genpd_dev_pm_attach);
>
>  /***        debugfs support        ***/
>
> -#ifdef CONFIG_PM_ADVANCED_DEBUG
> +#ifdef CONFIG_DEBUG_FS
>  #include <linux/pm.h>
>  #include <linux/device.h>
>  #include <linux/debugfs.h>
> @@ -1784,4 +1784,4 @@ static void __exit pm_genpd_debug_exit(void)
>         debugfs_remove_recursive(pm_genpd_debugfs_dir);
>  }
>  __exitcall(pm_genpd_debug_exit);
> -#endif /* CONFIG_PM_ADVANCED_DEBUG */
> +#endif /* CONFIG_DEBUG_FS */
> --
> 2.1.4
>