linux-kernel - Re: [PATCH] usb: chipidea: delete an useless header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3abe437c-7fab-339d-ad66-8db2456fbdb0@cogentembedded.com>
Date:   Fri, 19 Aug 2016 15:30:01 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jisheng Zhang <jszhang@...vell.com>, Peter.Chen@....com,
        gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] usb: chipidea: delete an useless header file

Hello.

On 8/19/2016 3:05 PM, Jisheng Zhang wrote:

> <linux/phy.h> is for net phy drivers, we don't need it.
>
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> ---
>  drivers/usb/chipidea/core.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 69426e6..ae12595 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -62,7 +62,6 @@
>  #include <linux/usb/chipidea.h>
>  #include <linux/usb/of.h>
>  #include <linux/of.h>
> -#include <linux/phy.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/usb/ehci_def.h>

    You're deleting an #include, not a file (as you say in the subject).

MBR, Sergei