| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1471613262-20682-9-git-send-email-benjamin.tissoires@redhat.com> Date: Fri, 19 Aug 2016 15:27:40 +0200 From: Benjamin Tissoires <benjamin.tissoires@...hat.com> To: Jean Delvare <jdelvare@...e.com>, Wolfram Sang <wsa@...-dreams.de> Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH v2 08/10] i2c: i2c-smbus: fix return value of i2c_handle_smbus_host_notify() schedule_work() returns a boolean (true on success, false if the work was already queued). This doesn't match the "negative number on error" return model that the function exports. Given that schedule_work() will always return true (we have an internal .pending check protected by a spinlock), just return false and ignore the return value of schedule_work(). Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com> --- new in v2 --- drivers/i2c/i2c-smbus.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c index 819e5f2..f6780de 100644 --- a/drivers/i2c/i2c-smbus.c +++ b/drivers/i2c/i2c-smbus.c @@ -357,7 +357,10 @@ int i2c_handle_smbus_host_notify(struct smbus_host_notify *host_notify, host_notify->pending = true; spin_unlock_irqrestore(&host_notify->lock, flags); - return schedule_work(&host_notify->work); + /* schedule_work is called if .pending is false, so it can't fail. */ + schedule_work(&host_notify->work); + + return 0; } EXPORT_SYMBOL_GPL(i2c_handle_smbus_host_notify); -- 2.5.5
Powered by blists - more mailing lists