linux-kernel - Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1471616119.61594.465.camel@infradead.org>
Date:   Fri, 19 Aug 2016 15:15:19 +0100
From:   David Woodhouse <dwmw2@...radead.org>
To:     Finlye Xiao <finley.xiao@...k-chips.com>,
        srinivas.kandagatla@...aro.org, maxime.ripard@...e-electrons.com,
        heiko@...ech.de, robh+dt@...nel.org, frowand.list@...il.com,
        sre@...nel.org, dbaryshkov@...il.com, mark.rutland@....com,
        khilman@...nel.org, nm@...com, rjw@...ysocki.net,
        viresh.kumar@...aro.org, sboyd@...eaurora.org
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        wxt@...k-chips.com, jay.xu@...k-chips.com,
        rocky.hao@...k-chips.com, tim.chen@...k-chips.com,
        tony.xie@...k-chips.com, ulysses.huang@...k-chips.com,
        lin.huang@...k-chips.com
Subject: Re: [PATCH v1 2/3] of: Add support for reading a s32 from a
 multi-value property.

On Tue, 2016-08-16 at 10:38 +0800, Finlye Xiao wrote:
> From: Finley Xiao <finley.xiao@...k-chips.com>
> 
> This patch adds an of_property_read_s32_index() function to allow
> reading a single indexed s32 value from a property containing multiple
> s32 values.
> 
> Signed-off-by: Finley Xiao <finley.xiao@...k-chips.com>

NAK.

Nobody should be using the old of_property_* functions any more anyway.
You should be using the generic device_propery_* functions which work
regardless of where the information comes from (actual DT vs. ACPI
_DSD).

So no, don't *add* any more of these functions. Only add the generic
version. And if your driver isn't using the generic property
functions... fix it.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation
Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5760 bytes)