linux-kernel - Re: [PART2 PATCH v6 12/12] svm: Implements update_pi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160819150405.GA5282@potion>
Date:   Fri, 19 Aug 2016 17:04:06 +0200
From:   Radim Krčmář <rkrcmar@...hat.com>
To:     Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
Cc:     joro@...tes.org, pbonzini@...hat.com, alex.williamson@...hat.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        sherry.hurwitz@....com
Subject: Re: [PART2 PATCH v6 12/12] svm: Implements update_pi_irte hook to
 setup posted interrupt

2016-08-19 16:49+0200, Radim Krčmář:
>   Minor design note:
>   To make the usage of "struct amd_ir_data" safer, we could pass "struct
>   list_head" into irq_set_vcpu_affinity(), instead of returning "struct
>   amd_ir_data *".
> 
>   irq_set_vcpu_affinity() would add "struct amd_ir_data" to the list only
>   if ir_data was not already in some list and report whether the list
>   was modified.

No, this would not simplify the search.  An important point of list_head
in amd_ir_data was to let us know the current list.