linux-kernel - Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160819154537.GF18515@leon.nu>
Date:   Fri, 19 Aug 2016 18:45:37 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     "Marciniszyn, Mike" <mike.marciniszyn@...el.com>
Cc:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Doug Ledford <dledford@...hat.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        "Hefty, Sean" <sean.hefty@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its
 implementation

On Fri, Aug 19, 2016 at 03:42:29PM +0000, Marciniszyn, Mike wrote:
> > >
> > > The bail_tmp: label is then not needed.
> > 
> > You still need to free tmp allocation if qib_eeprom_write failed and this is
> > your bail_tmp.
> > 
> 
> Typo.   The bail: label is not needed.

Yeah, it makes sense.

Thanks

> 
> Mike

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)