linux-kernel - Re: [PATCH 18/22] IB/mlx4/mcg: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160819155055.GK18515@leon.nu>
Date:   Fri, 19 Aug 2016 18:50:55 +0300
From:   Leon Romanovsky <leonro@...lanox.com>
To:     Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:     Yishai Hadas <yishaih@...lanox.com>,
        Doug Ledford <dledford@...hat.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Chuck Lever <chuck.lever@...cle.com>,
        Mark Bloch <markb@...lanox.com>,
        Hans Westgaard Ry <hans.westgaard.ry@...cle.com>,
        Christoph Lameter <cl@...ux.com>,
        Erez Shitrit <erezsh@...lanox.com>,
        Haggai Eran <haggaie@...lanox.com>,
        Florian Westphal <fw@...len.de>,
        Guy Shapiro <guysh@...lanox.com>, Eli Cohen <eli@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Faisal Latif <faisal.latif@...el.com>,
        Matan Barak <matanb@...lanox.com>,
        Chien Tin Tung <chien.tin.tung@...el.com>,
        Mustafa Ismail <mustafa.ismail@...el.com>,
        Shiraz Saleem <shiraz.saleem@...el.com>,
        Tatyana Nikolova <tatyana.e.nikolova@...el.com>,
        Steve Wise <swise@...lsio.com>,
        Mike Marciniszyn <infinipath@...el.com>,
        Bart Van Assche <bart.vanassche@...disk.com>,
        Yotam Kenneth <yotamke@...lanox.com>,
        Somnath Kotur <Somnath.Kotur@...gotech.Com>,
        Moni Shoua <monis@...lanox.com>,
        Shachar Raindel <raindel@...lanox.com>,
        Parav Pandit <pandit.parav@...il.com>,
        Sagi Grimberg <sagi@...mberg.me>,
        Christoph Hellwig <hch@...radead.org>,
        Dean Luick <dean.luick@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        Kaike Wan <kaike.wan@...el.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH 18/22] IB/mlx4/mcg: Remove deprecated
 create_singlethread_workqueue

On Mon, Aug 15, 2016 at 11:43:35PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
> 
> The workqueue "mcg_wq" queues work items &group->work
> and &group->timeout_work.
> 
> The workqueue "clean_wq" queues work item mcg_clean_task.
> 
> Both have been identity converted.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
> ---

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>

>  drivers/infiniband/hw/mlx4/mcg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/mcg.c b/drivers/infiniband/hw/mlx4/mcg.c
> index 8f7ad07..7d30be0 100644
> --- a/drivers/infiniband/hw/mlx4/mcg.c
> +++ b/drivers/infiniband/hw/mlx4/mcg.c
> @@ -1045,7 +1045,7 @@ int mlx4_ib_mcg_port_init(struct mlx4_ib_demux_ctx *ctx)
> 
>  	atomic_set(&ctx->tid, 0);
>  	sprintf(name, "mlx4_ib_mcg%d", ctx->port);
> -	ctx->mcg_wq = create_singlethread_workqueue(name);
> +	ctx->mcg_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
>  	if (!ctx->mcg_wq)
>  		return -ENOMEM;
> 
> @@ -1246,7 +1246,7 @@ void clean_vf_mcast(struct mlx4_ib_demux_ctx *ctx, int slave)
> 
>  int mlx4_ib_mcg_init(void)
>  {
> -	clean_wq = create_singlethread_workqueue("mlx4_ib_mcg");
> +	clean_wq = alloc_ordered_workqueue("mlx4_ib_mcg", WQ_MEM_RECLAIM);
>  	if (!clean_wq)
>  		return -ENOMEM;
> 
> --
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)