linux-kernel - Re: [PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160819171732.GH20499@dtor-ws>
Date:   Fri, 19 Aug 2016 10:17:32 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     LABBE Corentin <clabbe.montjoie@...il.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] input: pixcir_i2c_ts: simplify code with
 of_device_get_match_data

On Wed, Aug 17, 2016 at 03:22:12PM +0200, LABBE Corentin wrote:
> The usage of of_device_get_match_data reduce the code size a bit.
> Furthermore, it is better to use a standard function for
> getting the match data.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/pixcir_i2c_ts.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index d159e14..b0a2dc2 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -431,13 +431,7 @@ static const struct of_device_id pixcir_of_match[];
>  static int pixcir_parse_dt(struct device *dev,
>  			   struct pixcir_i2c_ts_data *tsdata)
>  {
> -	const struct of_device_id *match;
> -
> -	match = of_match_device(of_match_ptr(pixcir_of_match), dev);
> -	if (!match)
> -		return -EINVAL;
> -
> -	tsdata->chip = (const struct pixcir_i2c_chip_data *)match->data;
> +	tsdata->chip = of_device_get_match_data(dev);
>  	if (!tsdata->chip)
>  		return -EINVAL;
>  
> -- 
> 2.7.3
> 

-- 
Dmitry