linux-kernel - Re: DAX can not work on virtual nvdimm device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160819183047.GA7216@linux.intel.com>
Date:   Fri, 19 Aug 2016 12:30:47 -0600
From:   Ross Zwisler <ross.zwisler@...ux.intel.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     Xiao Guangrong <guangrong.xiao@...ux.intel.com>,
        Yumei Huang <yuhuang@...hat.com>, KVM <kvm@...r.kernel.org>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "qemu-devel@...gnu.org" <qemu-devel@...gnu.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux ACPI <linux-acpi@...r.kernel.org>,
        Stefan Hajnoczi <stefanha@...hat.com>
Subject: Re: DAX can not work on virtual nvdimm device

On Fri, Aug 19, 2016 at 07:59:29AM -0700, Dan Williams wrote:
> On Fri, Aug 19, 2016 at 4:19 AM, Xiao Guangrong
> <guangrong.xiao@...ux.intel.com> wrote:
> >
> > Hi Dan,
> >
> > Recently, Redhat reported that nvml test suite failed on QEMU/KVM,
> > more detailed info please refer to:
> >    https://bugzilla.redhat.com/show_bug.cgi?id=1365721
> >
> > The reason for this bug is that the memory region created by mmap()
> > on the dax-based file was gone so that the region can not be found
> > in /proc/self/smaps during the runtime.
> >
> > This is a simple way to trigger this issue:
> >    mount -o dax /dev/pmem0 /mnt/pmem/
> >    vim /mnt/pmem/xxx
> > then 'vim' is crashed due to segment fault.
> >
> > This bug can be reproduced on your tree, the top commit is
> > 10d7902fa0e82b (dax: unmap/truncate on device shutdown), the kernel
> > configure file is attached.
> >
> > Your thought or comment is highly appreciated.
> 
> I'm going to be offline until Tuesday, but I will investigate when I'm
> back.  In the meantime if Ross or Vishal had an opportunity to take a
> look I wouldn't say "no" :).

I haven't been able to reproduce this vim segfault.  I'm using QEMU v2.6.0,
and the kernel commit you mentioned, and your kernel config.

Here's my QEMU command line:

sudo ~/qemu/bin/qemu-system-x86_64 /var/lib/libvirt/images/alara.qcow2 \
-machine pc,nvdimm -m 8G,maxmem=100G,slots=100  -object \
memory-backend-file,id=mem1,share,mem-path=/dev/pmem0,size=8G -device \
nvdimm,memdev=mem1,id=nv1 -smp 6 -machine pc,accel=kvm 

With this I'm able to mkfs the guest's /dev/pmem0, mount it with -o dax, and
write a file with vim.

Can you reproduce your results with a pmem device created via a memmap kernel
command line parameter in the guest?  You'll need to update your kernel
config to enable CONFIG_X86_PMEM_LEGACY and CONFIG_X86_PMEM_LEGACY_DEVICE.