linux-kernel - Re: [PATCH] lib/Kconfig.debug: fix typo in select statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160820182013.GN3482@linux.vnet.ibm.com>
Date:   Sat, 20 Aug 2016 11:20:13 -0700
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     Valentin Rothberg <valentinrothberg@...il.com>
Cc:     keescook@...omium.org, rostedt@...dmis.org,
        linux-kernel@...r.kernel.org, pebolle@...cali.nl, ziegler@...fau.de
Subject: Re: [PATCH] lib/Kconfig.debug: fix typo in select statement

On Sat, Aug 20, 2016 at 12:16:10PM +0200, Valentin Rothberg wrote:
> Commit 484f29c7430b3 ("bug: Provide toggle for BUG on data corruption")
> added a Kconfig select statement on CONFIG_DEBUG_LIST, but the CONFIG_
> prefix is only used in Make and C(PP) syntax.  Remove the CONFIG_ prefix
> to correctly select the Kconfig option DEBUG_LIST.
> 
> Signed-off-by: Valentin Rothberg <valentinrothberg@...il.com>

Well, color me blind!

Good catch, queued for review and testing.

Kees, Steve, Rik, any objections?

							Thanx, Paul

> ---
> I detected the issue with scripts/checkkconfigsymbols.py
> 
>  lib/Kconfig.debug | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 5dea4d0a5a07..c2bbaae13d04 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2009,7 +2009,7 @@ config TEST_STATIC_KEYS
> 
>  config BUG_ON_DATA_CORRUPTION
>  	bool "Trigger a BUG when data corruption is detected"
> -	select CONFIG_DEBUG_LIST
> +	select DEBUG_LIST
>  	help
>  	  Select this option if the kernel should BUG when it encounters
>  	  data corruption in kernel memory structures when they get checked
> -- 
> 2.9.3
>