linux-kernel - Re: [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 21 Aug 2016 16:12:14 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matt Ranostay <mranostay@...il.com>,
        Colin King <colin.king@...onical.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Sanchayan Maity <maitysanchayan@...il.com>,
        Gregor Boirie <gregor.boirie@...rot.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val
 assignment

On 27/07/16 10:28, Matt Ranostay wrote:
> On Mon, Jul 25, 2016 at 3:06 PM, Colin King <colin.king@...onical.com> wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Fix an incorrect assignment due to a typo on a variable name. The
>> variable val2 should be assigned 100000 and not val.
> 
> Yikes! Good catch..
> 
> Reviewed-By: Matt Ranostay <mranostay@...il.com>
> 
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Thanks Colin.

Applied to the fixes-togreg branch of iio.git. Should head upstream
in a day or two.

Jonathan
>> ---
>>  drivers/iio/chemical/atlas-ph-sensor.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
>> index ae038a5..407f141 100644
>> --- a/drivers/iio/chemical/atlas-ph-sensor.c
>> +++ b/drivers/iio/chemical/atlas-ph-sensor.c
>> @@ -434,7 +434,7 @@ static int atlas_read_raw(struct iio_dev *indio_dev,
>>                         break;
>>                 case IIO_ELECTRICALCONDUCTIVITY:
>>                         *val = 1; /* 0.00001 */
>> -                       *val = 100000;
>> +                       *val2 = 100000;
>>                         break;
>>                 case IIO_CONCENTRATION:
>>                         *val = 0; /* 0.000000001 */
>> --
>> 2.8.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>