linux-kernel - [PATCH 3.10 173/180] be2iscsi: Fix bogus WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1471793510-13022-174-git-send-email-w@1wt.eu>
Date:   Sun, 21 Aug 2016 17:31:43 +0200
From:   Willy Tarreau <w@....eu>
To:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
Cc:     Tim Gardner <tim.gardner@...onical.com>,
        Jayamohan Kallickal <jayamohan.kallickal@...gotech.com>,
        Minh Tran <minh.tran@...gotech.com>,
        John Soni Jose <sony.john-n@...gotech.com>,
        "James E.J. Bottomley" <JBottomley@...n.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Willy Tarreau <w@....eu>
Subject: [PATCH 3.10 173/180] be2iscsi: Fix bogus WARN_ON length check

From: Tim Gardner <tim.gardner@...onical.com>

commit dd29dae00d39186890a5eaa2fe4ad8768bfd41a9 upstream.

drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
  WARN_ON(!length > 0);

gcc version 5.2.1

Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
Cc: Jayamohan Kallickal <jayamohan.kallickal@...gotech.com>
Cc: Minh Tran <minh.tran@...gotech.com>
Cc: John Soni Jose <sony.john-n@...gotech.com>
Cc: "James E.J. Bottomley" <JBottomley@...n.com>
Reported-by: Joel Stanley <joel@....id.au>
Reviewed-by: Manoj Kumar <manoj@...ux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>
Signed-off-by: Willy Tarreau <w@....eu>
---
 drivers/scsi/be2iscsi/be_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index a683a83..0227813 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -2978,7 +2978,7 @@ be_sgl_create_contiguous(void *virtual_address,
 {
 	WARN_ON(!virtual_address);
 	WARN_ON(!physical_address);
-	WARN_ON(!length > 0);
+	WARN_ON(!length);
 	WARN_ON(!sgl);
 
 	sgl->va = virtual_address;
-- 
2.8.0.rc2.1.gbe9624a