linux-kernel - Re: [PATCH] iio: ad5755: fix off-by-one on devnr limit check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ed48869-735a-002b-d89e-b1a694d19b6e@metafoo.de>
Date:   Sun, 21 Aug 2016 22:07:33 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Jonathan Cameron <jic23@...nel.org>,
        Colin King <colin.king@...onical.com>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: ad5755: fix off-by-one on devnr limit check

On 08/21/2016 09:30 PM, Jonathan Cameron wrote:
> On 25/07/16 23:40, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The comparison for devnr limits is off-by-one, the current check
>> allows 0 to AD5755_NUM_CHANNELS and the limit should be in fact
>> 0 to AD5755_NUM_CHANNELS - 1.  This can lead to an out of bounds
>> write to pdata->dac[devnr]. Fix this by replacing > with >= on the
>> comparison.
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Lars? 
> 
> Looks correct to me.
> 
> I'd also like a fixes tag for this if possible.  Guessing it
> might well be the original driver introduction but best to be
> sure ;)

It's new in 4.8-rc1. It was introduced by the devictree support patch.

Fixes: c947459979c6 ("iio: ad5755: add support for dt bindings")