lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 21 Aug 2016 18:06:34 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Rithvik Patibandla <rithvikp98@...il.com>
Cc:     sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
        linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:sm750fb:ddk750_chip.c:Fixed coding style in
 comments

On Sun, Jun 12, 2016 at 07:00:41PM +0530, Rithvik Patibandla wrote:
> The following patch fixes format of some comments.
> 
> Signed-off-by: Rithvik Patibandla <rithvikp98@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 71 +++++++++++++++++++----------------
>  1 file changed, 38 insertions(+), 33 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index f80ee77..8cb5cb9 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -70,11 +70,11 @@ static void setChipClock(unsigned int frequency)
>  		pll.inputFreq = DEFAULT_INPUT_CLOCK; /* Defined in CLOCK.H */
>  		pll.clockType = MXCLK_PLL;
>  
> -		/*
> -		* Call calcPllValue() to fill up the other fields for PLL structure.
> -		* Sometime, the chip cannot set up the exact clock required by User.
> -		* Return value from calcPllValue() gives the actual possible clock.
> -		*/
> +	/*
> +	 * Call calcPllValue() to fill up the other fields for PLL structure.
> +	 * Sometime, the chip cannot set up the exact clock required by User.
> +	 * Return value from calcPllValue() gives the actual possible clock.
> +	 */

Really?  Does that look correct to you?

hint your indentation is totally wrong :(

Please be more careful...

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ